On Tue, Aug 28, 2007 at 02:05:30PM -0700, Arjan van de Ven wrote:
> bnx2.c (incorrectly) sets current->state directly to
> TASK_UNINTERRUPTIBLE, without going through set_task_state(). However
> all the code wants to do is an msleep so just make it do that instead...

>               REG_WR(bp, BNX2_PCICFG_MISC_CONFIG, val);
>  
>               if ((CHIP_ID(bp) == CHIP_ID_5706_A0) ||
> -                 (CHIP_ID(bp) == CHIP_ID_5706_A1)) {
> -                     current->state = TASK_UNINTERRUPTIBLE;
> -                     schedule_timeout(HZ / 50);
> -             }
> +                 (CHIP_ID(bp) == CHIP_ID_5706_A1))
> +                     msleep(20);

Umm, a msleep just after a register write awfully sounds like a posting
bug waiting to happen to me..

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to