Hi Dave, David Miller <[EMAIL PROTECTED]> wrote on 09/17/2007 04:47:48 AM:
> The only major complaint I have about this patch series is that > the IPoIB part should just be one big changeset. Otherwise the > tree is not bisectable, for example the initial ipoib header file > change breaks the build. Right, I will change it accordingly. > On a lower priority, I question the indirection of skb_blist by making > it a pointer. For what? Saving 12 bytes on 64-bit? That kmalloc()'d > thing is a nearly guarenteed cache and/or TLB miss. Just inline the > thing, we generally don't do crap like this anywhere else. The intention was to avoid having two flags (one that driver supports batching and second to indicate that batching is on/off). So I could test skb_blist as an indication of whether batching is on/off. But your point on cache miss is absolutely correct, and I will change this part to be inline. thanks, - KK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
