On Wednesday 19 September 2007 22:00, Michael Chan wrote: > On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote: > + /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename) > + * is stripped, 32-bit unpacked size (LE) is prepended instead */ > + sz = *zbuf++; > + sz = (sz << 8) + *zbuf++; > + sz = (sz << 8) + *zbuf++; > + sz = (sz << 8) + *zbuf++; > > I don't have a problem with removing the gzip header. It doesn't > contain very useful information other than a valid header for sanity > check. But I don't think we need to arbitrarily add the unpacked size > in front of the gzipped data. The driver knows the size (e.g. the size > of RAM on the chip) and should pass it to the call. The driver should > also allocate the memory for the unpacked data instead of allocating the > memory inside the call and freeing it by the caller. For example, the > driver may need to use pci_alloc_consistent() if the firmware is to be > DMA'ed to the chip. > > Other than that, everything else looks fine. Thanks.
Are you saying that you successfully run-tested it? -- vda - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
