Hi,

On Thu, Sep 27, 2007 at 06:58:07AM -0700, Stephen Hemminger wrote:
> On Thu, 27 Sep 2007 09:14:11 +0100 Jochen Voß <[EMAIL PROTECTED]> wrote:
> > On 27 Sep 2007, at 01:58, Stephen Hemminger wrote:
> > > + /* This chip has hardware problems that generates bogus status.
> > > +  * So do only marginal checking and expect higher level protocols
> > > +  * to handle crap frames.
> > > +  */
> > > + if (sky2->hw->chip_id == CHIP_ID_YUKON_FE_P &&
> > > +     sky2->hw->chip_rev == CHIP_REV_YU_FE2_A0 &&
> > > +     length != count)
> > > +         goto okay;
> > 
> > Shouldn't the condition be "length == count"?
> 
> No, the code is correct as is.  Basically if length == count, then
> the status field is correct, and the driver can go ahead and use it.
> If length != count, then the status is bogus but the data is okay.

Oh, I see.  Thanks for the explanation.

All the best,
Jochen
-- 
http://seehuhn.de/

Attachment: signature.asc
Description: Digital signature

Reply via email to