On Wed, 03 Oct 2007 17:44:53 +0200
Peter Zijlstra <[EMAIL PROTECTED]> wrote:

> Subject: net: fix race in process_backlog
> 
> The recent NAPI rework (4fa57c9ea9f36f9ca852f3a88ca5d2f1aebbc960)
> introduced a race between netif_rx() and process_backlog() which
> resulted in softirq processing to drop dead.
> 
> netif_rx()            process_backlog()
> 
>                       irq_disable();
>                       skb = __skb_dequeue();
>                       irq_enable();
> 
> irq_disable();
> __skb_queue_tail();
> napi_schedule();
> irq_enable();
> 
>                       if (!skb)
>                         napi_complete();  <-- oops!
> 
> we cleared the napi bit, even though there is data to process.
> 
> Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]>

Acked-by: Stephen Hemminger <[EMAIL PROTECTED]>


-- 
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to