David Miller wrote:
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 2 Oct 2007 14:52:36 -0700
Please consider using netif_msg_xxx() and module parameter to set
default message level, like other real network drivers already do.
I keep seeing this recommendation, but the two supposedly most mature
and actively used drivers in the tree, tg3 and e1000 and e1000e, all
do not use this scheme.
In fact there are tons of drivers that even hook up the ethtool
msg_level setting function and never even use the value.
If people aren't using netif_msg_xxx() and the ethtool msg_level
facilities properly, it's because there is a severe dearth of good
example drivers to learn about it from.
The currently available CAN netdevice drivers do not have a common debug
concept neither any runtime control mechanism for this debugging. So
netif_msg_xxx() is definitely worth to look at instead of creating any
new stuff in this direction, before posting any 'real' CAN network
driver here.
Thanks very much for that hint!
Oliver
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
