On Thu, 11 Oct 2007 17:40:26 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:

> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 17:31:49 -0700
> 
> > You don't need to re-read the status register and process the PHY irq's 
> > inside loop.
> > Try this:
> 
> Are you sure?  What if a PHY interrupt comes in during the loop?

The interrupt is level triggered, and will rearm.

> 
> I'm just preserving the semantics of the driver when ->poll()
> is invoked multiple times per interrupt.
> 
> And I think preserving that makes sense while we're purely
> trying to fix this bug, so we don't add some new ones.


-- 
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to