Oliver Neukum wrote:
Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
 static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
 {
        struct usbnet *dev = netdev_priv(netdev);
+       void *buf;
        u16 res;
mutex_lock(&dev->phy_mutex);
        asix_set_sw_mii(dev);
+
+       buf = kmalloc(2, GFP_KERNEL);

This is done under lock. Can you allocate the buffer once and reuse it?

        Regards
                Oliver

I think we can use 2 bytes of the usbnet data buffer for this.
I'll submit a new patch soon.
Thanks,
Valentine.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to