On Thu, Oct 25, 2007 at 05:12:04AM -0400, Jeff Garzik wrote: > >+struct rx_desc { > >+ u32 cmd_sts; > >+ u16 size; > >+ u16 count; > >+ u32 buf; > >+ u32 next; > >+}; > >+ > >+struct tx_desc { > >+ u32 cmd_sts; > >+ u16 l4i_chk; > >+ u16 count; > >+ u32 buf; > >+ u32 next; > >+}; > > should use sparse type (__le32, etc.) and make sure this driver passes > sparse checks > > ditto for checkpatch (except for the excessively anal stuff)
Sorry if it wasn't clear from the thread -- the mainline mv643xx_eth driver turns out to support the same silicon block (but as part of a different chip), so we've dropped orion_eth and submitted patches to make mv643xx_eth work on both the Discovery (what it was originally written for) and the Orion, and these patches are in -rc1 already. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html