Sivakumar Subramani wrote:
- Fixed memory leak by freeing MSI-X local entry memories when vector allocation
fails in s2io_add_isr.
- Added two utility functions do_rem_msix_isr and do_rem_inta_isr to eliminate
code duplication.
Signed-off-by: Veena Parat <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Comments:
1) stats->mem_freed is redundant to general kernel debugging facilities
2) synchronize_irq() is redundant, free_irq() does same
3) "rem" isn't very clear. few if any other kernel drivers use this to
indicate "remove"
4) "do_" prefix is redundant
5) scripts/checkpatch.pl fails on this patch. please clean up problems.
The main issue for this patch is #2, though presumably the other stuff
can be cleaned on the next resubmit
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
