Jeff Garzik wrote: > Auke Kok wrote: >> Since data can never exceed u32, it can't even be larger than >> LONG_MAX/HZ. >> >> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> >> Cc: [EMAIL PROTECTED] >> --- >> > Two comments: > > 1) I would prefer to pick a sane limit, like "1 day". The unit of > 'data' is seconds, so IMO we should not allow stupid timeouts, much less > INT_MAX ones :) But hey, then again, maybe we should permit root to > hang themselves with own rope...
well, in this case it's only used for the blink interval for the LED on the back of the adapter. This is completely interruptable by the user with ^C when running ethtool, so it's not going to hang anything (traffic should continue nicely). yes INT_MAX is insanely long. moving all of this checking to the ethtool generic code makes much more sense indeed. > 2) [tangent] someone really should add the obvious ssleep_interruptible() *pass* :) Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
