On Wed, 07 Nov 2007 14:45:18 -0800 "Kok, Auke" <[EMAIL PROTECTED]> wrote:
> [adding netdev, jeff G to the Cc] > > Linas Vepstas wrote: > > On Wed, Nov 07, 2007 at 01:50:17PM -0800, Kok, Auke wrote: > >> Linas Vepstas wrote: > >>> If a PCI bus error is encountered during device open, the > >>> error recovery routines will attempt to close the device. > >>> If napi has not yet been enabled, the napi disable in the > >>> close will hang. > >>> > >>> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > >>> > >>> ---- > >>> The "elegence" of this solution is arguable: one could > >>> say its "better" to perform this check in e1000_down(). > >>> However, doing so will disrupt a commonly used path, > >>> whereas here, the hack is in the infrequently used > >>> error path, and thus less intrusive. > >>> Same problem might be possible in suspend/resume. The problem with testing napi_enabled is that state can get changed by racing irq. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
