On Tue, Nov 27, 2007 at 07:21:08PM +0300, Pavel Emelyanov wrote: > This hook is protected with the RCU, so simple > > if (br_should_route_hook) > br_should_route_hook(...) > > is not enough on some architectures. > > Use the rcu_dereference/rcu_assign_pointer in this case. > > Fixed Stephen's comment concerning using the typeof(). > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Applied to net-2.6. Thanks Pavel! > static void __exit ebtable_broute_fini(void) > { > - br_should_route_hook = NULL; > + rcu_assign_pointer(br_should_route_hook, NULL); Just for the record, rcu_assign_pointer is never necessary when you're assigning NULL. The reason is that rcu_assign_pointer serves as a barrier between the initialisation of the content of what you're assigning and the actual assignment. Since NULL does not need to be initialised you don't need the barrier :) Hmm, perhaps we could even build this logic into rcu_assign_pointer. Then again, who still uses an Alpha? Mine died years ago :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html