From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 20:07:29 +0800
> [IPSEC]: Fix potential dst leak in xfrm_lookup > > If we get an error during the actual policy lookup we don't free the > original dst while the caller expects us to always free the original > dst in case of error. > > This patch fixes that. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Sigh, thanks for fixing this. Applied to net-2.6 and I'll toss it over to -stable too. I bet the __xfrm_lookup() callers could stand a major audit, with the special -EREMOTE logic I bet there are non-EREMOTE code paths there that don't handle the dst ref semantics properly. This is a very error prone interface, both at the implementation and in the callers. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html