On Mon, 17 Dec 2007 12:47:59 -0500 "Parag Warudkar" <[EMAIL PROTECTED]> wrote:
> On Dec 17, 2007 12:00 PM, Stephen Hemminger > <[EMAIL PROTECTED]> wrote: > > > > > > > > > > a) drivers/net/sky2.c - watchdog_timer. This was showing up high on > > > > > Powertop's list of things that cause routine wakeups from idle. After > > > > > converting to init_timer_deferrable() the wakeups went down and this > > > > > one > > > > > no longer shows up in powertop's list. 25% reduction. > > > > This surprises me because it is a 1 hz timer and uses round_jiffies() in > > the current kernel. > > I am using the current git and I already have low wakeups per second > to begin with - 5-7 and out of that 25% are attributed to sky2. Not > sure if that matches up with the 1 hz + round_jiffies() logic. > > But is it conceptually ok to make this deferrable? I suppose yes as > it's just a watchdog that checks if the link is up and delaying that > would not make a difference? I think you are going to wake up once a second anyway, so all it ends up changing is the accounting. Please check with the powertop developers. I'm fine with changing sky2, but it would be good if you could go through all the network drivers and fix them as well. -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
