On Sun, 16 Dec 2007 13:38:33 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 13:58:52 -0800 > > > This should fix the tehuti napi fence post problems by getting > > rid of priv->napi_stop, and setting weight to 32 (like other 10G). > > > > Also, used the wierd entry/exit macro's like rest of driver. > > It fixes the fench-post problem, but like the comments you > removed explain: > > > - /* from time to time we exit to let NAPI layer release > > - * device lock and allow waiting tasks (eg rmmod) to advance) */ > > - priv->napi_stop = 0; > > - > > We now hang on rmmod during constant packet load. > > This change just trades one bug for another, we have to > get the device close issue sorted out before we can go > around removing these things. Well the napi_stop had the same effect as having a smaller weight value, so my patch just shrunk the weight. That causes the device to exit NAPI (and should solve the rmmod problem). -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
