On Dec 13 2007 15:38, Joe Perches wrote: > >Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET >macros to inline functions ipv4_is_<type>(__be32 addr) > >Adds type safety and arguably some readability. > >Changes since last submission: > >Removed ipv4_addr_octets function >Used hex constants >Converted recently added rfc3330 macros > >Signed-off-by: Joe Perches <[EMAIL PROTECTED]> >--- >+static inline bool ipv4_is_loopback(__be32 addr) >+{ >+ return (addr & htonl(0xff000000)) == htonl(0x7f000000); >+} >+
Can we use __constant_htonl()? >+static inline bool ipv4_is_private_10(__be32 addr) >+{ >+ return (addr & htonl(0xff000000)) == htonl(0x0a000000); >+} What are these functions needed for, even? There does not seem to be any code (at least in davem's net-2.6.25:net/ipv4/, where I dared to grep) that uses them. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html