On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote:
>
>       do {
>               err = xfrm_state_check_space(x, skb);
> -             if (err)
> +             if (err) {
> +                     XFRM_INC_STATS(LINUX_MIB_XFRMOUTERROR);
>                       goto error_nolock;
> +             }
>  
>               err = x->outer_mode->output(x, skb);
> -             if (err)
> +             if (err) {
> +                     XFRM_INC_STATS(LINUX_MIB_XFRMOUTSTATEMODEERROR);

BTW, none of our existing mode output functions actually return
an error.  I noticed that the description for this field is actually
"Transformation mode specific error, e.g. Outer header space is not
enough".  This is slightly misleading as output header space is
checked by xfrm_state_check_space so if there's an error that's
where it'll show up.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to