(cc's added) On Mon, 14 Jan 2008 23:14:25 +0100 (CET) Krzysztof Oledzki <[EMAIL PROTECTED]> wrote:
> > > On Mon, 14 Jan 2008, [EMAIL PROTECTED] wrote: > > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Remove stray rtnl_unlock(). > > > > Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9542 > > > > Cc: "David S. Miller" <[EMAIL PROTECTED]> > > Cc: Stephen Hemminger <[EMAIL PROTECTED]> > > Cc: Krzysztof Oledzki <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > --- > > > > drivers/net/bonding/bond_sysfs.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix > > drivers/net/bonding/bond_sysfs.c > > --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix > > +++ a/drivers/net/bonding/bond_sysfs.c > > @@ -1111,8 +1111,6 @@ static ssize_t bonding_store_primary(str > > out: > > write_unlock_bh(&bond->lock); > > > > - rtnl_unlock(); > > - > > return count; > > } > > static DEVICE_ATTR(primary, S_IRUGO | S_IWUSR, bonding_show_primary, > > bonding_store_primary); > > _ > > > > http://thread.gmane.org/gmane.linux.network/82566/focus=83142 > That's bond_lock. This patch (below) addresses what appears to me to be an obvious imbalance in rtnl_lock. I don't care how it's fixed, really. Someone please fix it? From: Andrew Morton <[EMAIL PROTECTED]> Remove stray rtnl_unlock(). Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9542 Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Stephen Hemminger <[EMAIL PROTECTED]> Cc: Krzysztof Oledzki <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_sysfs.c | 2 -- 1 file changed, 2 deletions(-) diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix drivers/net/bonding/bond_sysfs.c --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix +++ a/drivers/net/bonding/bond_sysfs.c @@ -1111,8 +1111,6 @@ static ssize_t bonding_store_primary(str out: write_unlock_bh(&bond->lock); - rtnl_unlock(); - return count; } static DEVICE_ATTR(primary, S_IRUGO | S_IWUSR, bonding_show_primary, bonding_store_primary); _ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
