Ben Greear <[EMAIL PROTECTED]> writes:
> Dan Nicolaescu wrote:
> > Hi,
> >
> > I have posted this patch in the past with absolutely no reply.
> > I would appreciate some sort of feedback of the form interested/not
> > interested. Should I just drop it?
> >
> >
> I like it, but why not offer this for all devices since they all have
> these stats.
>
> Could add new handlers called something like .get_strings_generic, or
> just add this to the higher-level ethtool handling before it looks for
> handlers.
If I get your point, then the difference would be that drivers would add
to the initialization of the ethtool structure something like:
.get_strings_generic = 1;
instead of what I originally proposed:
.get_strings = ethtool_op_net_device_stats_get_strings,
.get_stats_count = ethtool_op_net_device_stats_get_stats_count,
.get_ethtool_stats = ethtool_op_net_device_get_ethtool_stats,
Sure that could work, but it would require a few lines of changes in
ethtool.
I can submit a patch that does things that way, if that is considered
better. But I would like to hear that this code is wanted before
putting any effort in it. I has been ignored for so long...
Thanks
--dan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
