On Sun, Feb 03, 2008 at 09:57:10AM +1100, Herbert Xu wrote: > Andi Kleen <[EMAIL PROTECTED]> wrote: > >> Then change TBF to use skb_gso_segment? Be careful, the fact that > > > > That doesn't help because it wants to interleave packets > > from different streams to get everything fair and smooth. The only > > good way to handle that is to split it up and the simplest way to do > > this is to just tell TCP to not do GSO in the first place. > > Actually if we're going to do this I'd prefer you to call skb_gso_segment > instead because that lets us at least bypass netfilter which is one of > the key benefits of software GSO.
Ok. The only problem I see right now is that skb_segment() seems to overuse GFP_ATOMIC which would make it unreliable, but that is something that can be fixed. -Andi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
