On Wed, Jan 30, 2008 at 10:02:07PM +0200, Adrian Bunk wrote: > This patch fixes the following section mismatch: > > <-- snip --> > > ... > WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in > reference from the function olympic_open() to the function > .devinit.text:olympic_init() > ... > > <-- snip --> > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > fd1e6e0bb5b17dc85cd24d6263e8751e816f59e6 > diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c > index e7b4adc..433c994 100644 > --- a/drivers/net/tokenring/olympic.c > +++ b/drivers/net/tokenring/olympic.c > @@ -434,7 +434,7 @@ static int __devinit olympic_init(struct net_device *dev) > > } > > -static int olympic_open(struct net_device *dev) > +static int __devinit olympic_open(struct net_device *dev) > { > struct olympic_private *olympic_priv=netdev_priv(dev); > u8 __iomem *olympic_mmio=olympic_priv->olympic_mmio,*init_srb; > >
If __devinit marked code is still discarded after initial setup then NACK. open can be called at any time the interface is ifup'ed. Its most definitely not adapter init code (that's all done in probe). Mike -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html