On Tue, Feb 19, 2008 at 09:03:12AM +0000, James Chapman wrote: > David Miller wrote: >> From: James Chapman <[EMAIL PROTECTED]> >> Date: Mon, 18 Feb 2008 22:09:24 +0000 >> >>> Here's a new version of the patch. The patch avoids disabling irqs >>> and fixes the sk_dst_get() usage that DaveM mentioned. But even with >>> this patch, lockdep still complains if hundreds of ppp sessions are >>> inserted into a tunnel as rapidly as possible (lockdep trace is >>> below). I can stop these errors by wrapping the call to ppp_input() >>> in pppol2tp_recv_dequeue_skb() with local_irq_save/restore. What is >>> a better fix? >> >> Firstly, let's fix one thing at a time. Leave the sk_dst_get() >> thing alone until we can prove that it's part of the lockdep >> traces. > > In reproducing the problem, I obtained several lockdep traces that > implicated sk_dst_get().
As a matter of fact I missed just that kind information on previous lockdep report, so if you could send them too this should be still helpful. ... > I agree. I'm seeking advice on what the underlying cause is of this new > trace. IMHO, just like I wrote earlier, the main problem is in ppp_generic(), especially ppp_connect_channel(), where main tx & rx locks are used. I didn't know enough about this sk_dst_lock traces yet. I hope I could help with this, but after these changes I need some time to figure this out again. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
