On Wed, 2008-02-20 at 19:27 +0300, Pavel Emelyanov wrote: > Patrick McHardy wrote: > > Joe Perches wrote: > >> On Wed, 2008-02-20 at 07:29 -0800, Joe Perches wrote: > >> > >>> fs/nfsd/nfsproc.c: char buf[RPC_MAX_ADDRBUFLEN]; > >>> Perhaps there should be a DECLARE_RPC_BUF(buf) macro? > >>> #define DECLARE_RPC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused > >>> > >> Make that: > >> > >> #define DECLARE_RPC_BUF(var) char var[RPC_MAX_ADDRBUFLEN] __maybe_unuse > > OK, I'll send the patch in a moment.
1) Please always Cc [EMAIL PROTECTED] when changing the sunrpc code 2) Please don't use the name RPC_BUF. These are debugging strings, not buffers. Something like DECLARE_RPC_DEBUG_STR() would be more appropriate. 3) If you're going to use a macro, why not just use the existing RPC_IFDEBUG()? Trond -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
