On Wed, 2008-02-20 at 20:57 -0600, Olof Johansson wrote: > plain text document attachment (in-progress) > Also stop both rx and tx sections before changing the configuration of > the dma device during init. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c > =================================================================== > --- k.org.orig/arch/powerpc/platforms/pasemi/dma_lib.c > +++ k.org/arch/powerpc/platforms/pasemi/dma_lib.c > @@ -478,6 +478,30 @@ int pasemi_dma_init(void) > for (i = 0; i < MAX_RXCH; i++) > __set_bit(i, rxch_free); > > + i = 1000; > + pasemi_write_dma_reg(PAS_DMA_COM_RXCMD, 0); > + while ((i > 0) && (pasemi_read_dma_reg(PAS_DMA_COM_RXSTA) & 1)) > + i--; > + if (i < 0) > + printk(KERN_INFO "Warning: Could not disable RX section\n"); > + > + i = 1000; > + pasemi_write_dma_reg(PAS_DMA_COM_TXCMD, 0); > + while ((i > 0) && (pasemi_read_dma_reg(PAS_DMA_COM_TXSTA) & 1)) > + i--;
This kind of caught my eye, is it still going to work when the next core is twice as fast? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
