From: Niklas Cassel <niklas.cas...@axis.com>
Date: Thu, 23 Apr 2015 15:37:11 +0200
> Signed-off-by: Niklas Cassel <nikl...@axis.com>
> ---
> drivers/net/phy/micrel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 1190fd8..a422036 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -548,7 +548,7 @@ static int kszphy_probe(struct phy_device *phydev)
> }
>
> clk = devm_clk_get(&phydev->dev, "rmii-ref");
> - if (!IS_ERR(clk)) {
> + if (!IS_ERR_OR_NULL(clk)) {
> unsigned long rate = clk_get_rate(clk);
> bool rmii_ref_clk_sel_25_mhz;
>
I do not see anyone in any other networking driver checking for a NULL
return from devm_clk_get().
So either everyone else is wrong, or your change is. I want to find
out which before applying anything.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
