From: Ivan Vecera <ivec...@redhat.com> Date: Tue, 28 Apr 2015 16:32:37 +0200
> On 04/23/2015 08:31 AM, Sathya Perla wrote: >>> -----Original Message----- >>> From: Ivan Vecera [mailto:ivec...@redhat.com] >>> >>> The driver unlike other drivers does not log link state changes. >>> >>> v2: added current link speed to log message >>> >> Ivan, I disagree with the v2 change. I think your original intention >> was just to log a message when the link goes up or down >> asynchronously (i.e., without any user intervention.) >> After alerting the user, if the user wants to know other link >> properties like speed, duplex etc then the ethtool cmd needs >> to be used; there is no need to log a message with those details. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe netdev" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > Dave, could we apply the v1 WRT Sathya's comment? Patches should be resubmitted freshly when people want me to do something like this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
