From: Konstantin Khlebnikov <khlebni...@yandex-team.ru> Date: Thu, 14 May 2015 16:56:18 +0300
> Unlike to inetaddr_chain inet6addr_chain is atomic and called from bh > context without rtnl when ipv6 receives router advertisement packet. > > Several drivers don't know about that: ipvlan thinks that it has rtnl > here, ocrdma locks mutex inside callback. Probably there is more. > > This patch makes it blocking and calls from first stage of DAD work. > Looks like this is completely safe and rtnl already locked here. > > Signed-off-by: Konstantin Khlebnikov <khlebni...@yandex-team.ru> I don't see how you can make the inet6addr_chain blocking when it is invoked from software interrupt context. You also cannot try to defer these operations to a workqueue or similar to get into a blockable context, because various ipv6 testsuites depend upon the addressing state change happening when we process the packet that triggers that change. Instead, I think you have to make the users of inet6addr_chain aware of the context in which they execute. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
