On Thu, 2015-05-21 at 11:39 +0200, Hannes Frederic Sowa wrote:
> unix_stream_recvmsg is refactored to unix_stream_read_generic in this
> patch and enhanced to deal with pipe splicing. The refactoring is
> inneglible, we mostly have to deal with a non-existing struct msghdr
> argument.
> 

> +static __always_inline
> +int unix_stream_read_generic(struct unix_stream_read_state *state)
>  {


I do not believe it is reasonable to inline this monster, even if some
macro benchmark looks better.

General trend in the community is to remove all these inlines.

ip_finish_output2() for example should lose its 'inline' keyword.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to