> Subject: Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter > > From: Hiroshi Shimamoto <h-shimam...@ct.jp.nec.com> > Date: Thu, 21 May 2015 13:10:49 +0000 > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > index 263cb40..b45570f 100644 > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > @@ -158,6 +158,10 @@ module_param(allow_unsupported_sfp, uint, 0); > > MODULE_PARM_DESC(allow_unsupported_sfp, > > "Allow unsupported and untested SFP+ modules on 82599-based > > adapters"); > > > > +static unsigned int disable_hw_vlan_filter; > > +module_param(disable_hw_vlan_filter, uint, 0); > > +MODULE_PARM_DESC(disable_hw_vlan_filter, "Disable HW VLAN filter"); > > Sorry, module parameters like this are not allowed. > > You must use a generic, portable interface, to configure networking > device settings.
Could you please tell me which interface is good for this? > > Otherwise every other driver that wants to do something similar will > have yet another module option with a different name, and every user > will suffer because they will need to learn a different mechanism > to perform this configuration for every driver. Right, I agree. But I thought that this requirement seems really special and closed in ixgbe driver, that the reason I tried it with module parameter. thanks, Hiroshi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
