From: Shradha Shah > Sent: 29 May 2015 11:01 > On every adapter there will be one primary PF per adaptor and > one link control PF per port. ... > + return sprintf(buf, "%d\n", > + ((efx->mcdi->fn_flags) & > + (1 << MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_LINKCTRL)) > + ? 1 : 0);
Horrid expression. Why not: (efx->mcdi->fn_flags >> MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_LINKCTRL) & 1 using sprintf() is also excessive. Maybe: *buf = '0' + (expression); return 1; You may also need to check for buffer overrun. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html