Hi Eric, Can you please tell us if this change would be for the better?
I was about to say yes to this request but checked and no other Ethernet driver seems to use the queue trans_start. I was able to find your patch "net: tx scalability works : trans_start" [ http://patchwork.ozlabs.org/patch/27104/ ] but did not find more about this topic. Thank you, Madalin > -----Original Message----- > From: Xie Jianhua-B29408 > Sent: Wednesday, June 10, 2015 9:00 AM > To: Bucur Madalin-Cristian-B32716; netdev@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Cc: linux-ker...@vger.kernel.org > Subject: RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet > > > > > -----Original Message----- > > From: Linuxppc-dev [mailto:linuxppc-dev- > > bounces+jianhua.xie=freescale....@lists.ozlabs.org] On Behalf Of > Madalin > > Bucur > > Sent: Wednesday, April 29, 2015 10:57 PM > > To: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org > > Cc: linux-ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > Subject: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet > > > > This introduces the Freescale Data Path Acceleration Architecture > > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > > the Freescale DPAA QorIQ platforms. > > > Snip...... > > > + > > + if (unlikely(dpa_xmit(priv, percpu_stats, queue_mapping, &fd) < 0)) > > + goto xmit_failed; > > + > > + net_dev->trans_start = jiffies; > > It is probably better to use netdev_queue->trans_start to instead of > net_dev->trans_start on SMP. > > Best Regards, > Jianhua > > > + return NETDEV_TX_OK; > > + > > +xmit_failed: > > + if (fd.cmd & FM_FD_CMD_FCO) { > > + (*countptr)--; > > + dpa_fd_release(net_dev, &fd); > > + percpu_stats->tx_errors++; > > + return NETDEV_TX_OK; > > + } > > + _dpa_cleanup_tx_fd(priv, &fd); > > + percpu_stats->tx_errors++; > > + dev_kfree_skb(skb); > > + return NETDEV_TX_OK; > > +} > > -- > > 1.7.11.7 > > > > _______________________________________________ > > Linuxppc-dev mailing list > > linuxppc-...@lists.ozlabs.org > > https://lists.ozlabs.org/listinfo/linuxppc-dev N�����r��y����b�X��ǧv�^�){.n�+���z�^�)����w* jg��� �����ݢj/���z�ޖ��2�ޙ����&�)ߡ�a���� �G���h��j:+v���w��٥
