On Tue, 2015-06-16 at 17:16 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
>
> > From: Jacob Keller <jacob.e.kel...@intel.com>
>
> > Fix up error message style to include a colon.
>
> > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com>
> > Tested-by: Krishneil Singh <krishneil.k.si...@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
> > ---
> > drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > index 445014a..5269b16 100644
> > --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > @@ -1773,7 +1773,7 @@ static int fm10k_probe(struct pci_dev *pdev,
> > fm10k_driver_name);
> > if (err) {
> > dev_err(&pdev->dev,
> > - "pci_request_selected_regions failed
> > 0x%x\n", err);
> > + "pci_request_selected_regions failed:
> > 0x%x\n", err);
>
> I don't think printing error in hexadecimal makes much sense, so
> you might
> as well fix that format to "%d"...
>
> WBR, Sergei
>
Sure thing.
Regards,
Jake
