From: Pavel Fedin <p.fe...@samsung.com>
Date: Tue, 23 Jun 2015 10:11:03 +0300

> This bug pops up with NetworkManager on Fedora 21. NetworkManager tends to
> stop the interface (nicvf_stop() is called) before changing settings. In
> stopped state MAC cannot be sent to a PF. However, when the interface is
> restarted (nicvf_open() is called), we ping the PF using NIC_MBOX_MSG_READY
> message, and the PF replies back with old MAC address, overriding what we
> had after MAC setting from userspace. As a result, we cannot set MAC
> address using NetworkManager.
> 
> This patch introduces special tracking of MAC change in stopped state so
> that the correct new MAC address is sent to a PF when interface is reopen.
> 
> Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
> ---
>  Differences from v1:
> - Fixed a couple of checkpatch.pl reports (was forgotten in v1)
> - Adjusted email client prefs, hopefully will not corrupt patches any more.

Still have problems:

> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h 
> b/drivers/net/ethernet/cavium/thunder/nic.h
> index a3b43e5..dda8a02 100755
> --- a/drivers/net/ethernet/cavium/thunder/nic.h
> +++ b/drivers/net/ethernet/cavium/thunder/nic.h
> @@ -263,6 +263,7 @@ struct nicvf {

This hunk makes 'git am' complain:

Applying: net: Cavium: Fix MAC address setting in shutdown state
warning: drivers/net/ethernet/cavium/thunder/nic.h has type 100644, expected 
100755
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to