On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote:
> From: Pravin Shelar <pshe...@nicira.com>
>
> Removes all of the OVS specific GRE code and makes OVS use a
> GRE net_device.
>
> Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
[snip]
> @@ -115,6 +117,8 @@ static bool log_ecn_error = true;
> module_param(log_ecn_error, bool, 0644);
> MODULE_PARM_DESC(log_ecn_error, "Log packets received with corrupted ECN");
>
> +#define GRE_TAP_FB_NAME "gretap0"
> +
> static struct rtnl_link_ops ipgre_link_ops __read_mostly;
> static int ipgre_tunnel_init(struct net_device *dev);
>
[snip]
> @@ -690,12 +836,27 @@ static const struct net_device_ops gre_tap_netdev_ops =
> {
> .ndo_get_iflink = ip_tunnel_get_iflink,
> };
>
> +static const struct net_device_ops gre_fb_netdev_ops = {
> + .ndo_init = gre_tap_init,
> + .ndo_uninit = ip_tunnel_uninit,
> + .ndo_start_xmit = gre_fb_xmit,
> + .ndo_set_mac_address = eth_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> + .ndo_change_mtu = ip_tunnel_change_mtu,
> + .ndo_get_stats64 = ip_tunnel_get_stats64,
> + .ndo_get_iflink = ip_tunnel_get_iflink,
> +};
> +
> static void ipgre_tap_setup(struct net_device *dev)
> {
> ether_setup(dev);
> - dev->netdev_ops = &gre_tap_netdev_ops;
> dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> ip_tunnel_setup(dev, gre_tap_net_id);
> +
> + if (!strcmp(dev->name, GRE_TAP_FB_NAME))
> + dev->netdev_ops = &gre_fb_netdev_ops;
> + else
> + dev->netdev_ops = &gre_tap_netdev_ops;
> }
>
> static int ipgre_newlink(struct net *src_net, struct net_device *dev,
[snip]
Is there a side-effect of the above that if a user creates a gretap device
whose name is "gretap0" then the device will use gre_fb_netdev_ops instead
of gre_tap_netdev_ops. If so, does that imply a change in behaviour for
gretap devices created with that name?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
