Patches are always appreciated and this looks like a real bug. But before I can accept it there are a couple of small changes needed.
1. There is no need to check for NULL when calling free(). Glibc free is documented to accept NULL as a valid request and do nothing. 2. Please add a Signed-off-by: line with a real name. Signed-off-by has legal meaning for the Developer's Certificate of Origin see kernel documentation if you need more explaination. 3. Although what you found is important, giving a full paragraph of personal comment about it is not required. The point is software should read like one source independent of who the authors are. Your comment is basically just justifying using strncpy. 4. Rather than strncpy() which has issues with maximal sized strings consider using strlcpy() instead. 5. Iproute2 uses kernel identation and style, consider running checkpatch on your changes. Please fixup and resubmit to netdev. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
