Hello,
On Tue, 21 Jul 2015, Martin KaFai Lau wrote:
> The patch checks neigh->nud_state before acquiring the writer lock.
> Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF.
Locking usage is absolutely correct.
> + if (!(neigh->nud_state & NUD_VALID) &&
> + time_after(jiffies, neigh->updated +
> rt->rt6i_idev->cnf.rtr_probe_interval)) {
but this line is too long...
> + work = kmalloc(sizeof(*work), GFP_ATOMIC);
> + if (work) {
> + __neigh_set_probe_once(neigh);
> + }
scripts/checkpatch.pl --strict /tmp/file.patch
Regards
--
Julian Anastasov <j...@ssi.bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
