From: Thomas Graf <tg...@suug.ch> Date: Wed, 22 Jul 2015 14:23:09 +0200
> On 07/22/15 at 12:10am, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> seen with CONFIG_IPV6 disabled. Wrap the code >> around IS_ENABLED(CONFIG_IPV6) >> >> Reported-by: kbuild test robot <fengguang...@intel.com> >> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> > > We need the same for CONFIG_INET=n in inet_fib_lookup_dev: > > /home/tgraf/dev/linux/net-next/include/net/route.h:122: undefined reference > to `ip_route_output_flow' > > Is it worth returning EAFNOSUPPORT instead of ENODEV in these > cases? Something like this: > >> } >> +#else >> +static struct net_device *inet6_fib_lookup_dev(struct net *net, void *addr) >> +{ > + return ERR_PTR(-EAFNOSUPPORT); >> +} >> +#endif > > And then IS_ERR() in mpls_route_add()? Also IS_ENABLED() _DOES NOT_ work, what if MPLS is 'y' and IPV6 is 'm'? You can't reache the modular symbol from statically built code. What a mess. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html