Mon, Jul 27, 2015 at 08:17:22AM CEST, rami.ro...@intel.com wrote: >Hi, Jiri, > >Keep on the good work! > >The .func member of the mlxsw_rx_listener object has this prototype: >void (*func)(struct sk_buff *skb, u8 local_port, u16 trap_id, void *priv); > >Is the trap_id parameter needed ? >In the three use cases of .func, which are either >mlxsw_emad_rx_listener_func(), mlxsw_core_event_listener_func(), or >mlxsw_sx_rx_listener_func(), this parameter is not used at all.
You are right. We intended to use MLXSW_TRAP_ID_DONT_CARE and use trap_id in the callback, but when user registers a callback for exact trap_id, this is not needed. Will remove in v2. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html