On 7/31/15 1:00 AM, Thomas Graf wrote:
On 07/30/15 at 08:10pm, Alexei Starovoitov wrote:
Two vxlan driver flags FLOWBASED and COLLECT_METADATA need to be set to
make use of its new flow mode. The former already exposed. Expose the latter.
Signed-off-by: Alexei Starovoitov <a...@plumgrid.com>
Since you are analyzing the program when you load it. Could you call
ip_tunnel_need_metadata() when we load a program which accesses
the new metadata field and ip_tunnel_unneed_metadata() when you unload
it? This would hide the need to set this flag from the user. The con
is that it enables metadata on all net_devices.
I thought about it, but the global static_key enabler via
ip_tunnel_collect_metadata() is an overkill when we only want
to enable it for one tunnel. I can imagine why you may need
it for routing, but every tunnel type needs its own
collect_metadata flag similar to vxlan.
Also in bpf there is no program scan at unload time.
To call ip_tunnel_unneed_metadata() cleanly, I would need to
extra global refcnt just for that. which is ugly.
I'm also fine with exposing this flag to the user though. I'll leave it
up to you so feel free to add my ack if you want to go this route.
Acked-by: Thomas Graf <tg...@suug.ch>
thanks. I think exposing collect_metadata for vxlan and in the future
for other tunnel types is the clean enough way, though the other
alternative would be to get rid of collect_metadata flag
from the kernel and do it when flowmode flag is set. Thoughts?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
