From: Jiri Pirko <j...@resnulli.us>
Date: Tue, 18 Aug 2015 07:55:55 +0200

> Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote:
>>+static int rocker_probe_debugfs_init(struct rocker *rocker)
>>+{
>>+     char dbg_dir_name[sizeof(rocker->hw.id) * 2 + 1];
>>+
>>+     sprintf(dbg_dir_name, "%*phN", (int)sizeof(rocker->hw.id),
>>+             &rocker->hw.id);
> 
> You can use PCI address here. Might be better.

This absolutely will not be unique in a multi-domain PCI configuration.

It is arguable whether that matters or not under qemu, but it's a bad
precedence to say that PCI addresses will be unique, they absolutely
are not unique between devices even of the same exact type.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to