On Wed, Aug 26, 2015 at 5:08 PM, Stephen Hemminger <step...@networkplumber.org> wrote: > On Wed, 26 Aug 2015 15:41:26 -0700 > Cong Wang <xiyou.wangc...@gmail.com> wrote: > >> Currently there is no check for if a qdisc is appropriate >> to be used as the default qdisc. This causes we get no >> error even we set the default qdisc to an inappropriate one >> but an error will be shown up later. This is not good. >> >> Also, for qdisc's like HTB, kernel will just crash when >> we use it as default qdisc, because some data structures are >> not even initialized yet before checking opt == NULL, the cleanup >> doing ->reset() or ->destroy() on them will just crash. > > Why not fix the buggy one's instead?
They are not exactly buggy, since they are fine in other ->init() calling cases. As in the first paragraph you quoted from me, it is more like a usability issue, for example ingress qdisc can be set as default without any error at any time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
