On Thu, 2015-06-11 at 15:15 +0300, Hadar Hen Zion wrote: > From: Govindarajulu Varadarajan <_gov...@gmx.com> > > Add support for setting/getting driver's tx/rx_copybreak value. > > Copybreak is handled through a new ethtool tunable interface. > > The kernel support was added in 3.18, commit f0db9b07341 "ethtool: > Add generic options for tunables" [...]
So why have you sent a patch that only handles copy-break? The kernel tells us the type of each tunable and ethtool should use that to decide how to print and parse values. Ben. -- Ben Hutchings friends: People who know you well, but like you anyway.
signature.asc
Description: This is a digitally signed message part
