On 9/9/15, 2:10 PM, David Miller wrote:
From: Roopa Prabhu <ro...@cumulusnetworks.com>
Date: Tue, 8 Sep 2015 10:53:04 -0700
This patch reduces the possibility of this by doing the following:
a) Changes the existing multipath route add code to a two stage process:
build rt6_infos + insert them
ip6_route_add rt6_info creation code is moved into
ip6_route_info_create.
b) This ensures that most errors are caught during building rt6_infos
and we fail early
c) Separates multipath add and del code. Because add needs the special
two stage mode in a) and delete essentially does not care.
d) In any event if the code fails during inserting a route again, a
warning is printed (This should be unlikely)
Looks good, follows the usual "prepare/commit" paradigm.
Applied, thanks.
For net-next, it might be nice to make ip6_route_info_create() return
error pointers instead of returning the rt pointer by reference.
ok, sounds good. Will post a patch with the error pointer to next-next
when it opens. thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
