>-----Original Message----- >From: Sudeep Holla [mailto:sudeep.ho...@arm.com] >Sent: Monday, September 21, 2015 6:47 PM >To: linux...@vger.kernel.org; linux-ker...@vger.kernel.org >Cc: Sudeep Holla <sudeep.ho...@arm.com>; Thomas Gleixner ><t...@linutronix.de>; Rafael J. Wysocki <r...@rjwysocki.net>; David S. Miller ><da...@davemloft.net>; Manoil Claudiu-B08782 ><claudiu.man...@freescale.com>; Kevin Hao <haoke...@gmail.com>; >netdev@vger.kernel.org >Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND >flag > >The device is set as wakeup capable using proper wakeup API but the >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source >which is incorrect. > >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >enable_irq_wake instead. >
What would be the purpose of IRQF_NO_SUSPEND flag then? The flag is a friendlier API compared to calling enable_irq_wake(). For older kernels, on PPC architectures, the flag did the job. When did this change? Since when using IRQF_NO_SUSPEND is a "misuse"? Thanks, Claudiu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html