On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
> drivers/usb/gadget/configfs.c | 295
> ++++++++++++++----------------------
> include/linux/usb/gadget_configfs.h | 19 +--
> 2 files changed, 118 insertions(+), 196 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 294eb74..163d305 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -64,6 +64,11 @@ struct gadget_info {
> char qw_sign[OS_STRING_QW_SIGN_LEN];
> };
>
> +static inline struct gadget_info *to_gadget_info(struct config_item *item)
> +{
> + return container_of(to_config_group(item), struct gadget_info, group);
> +}this (and the other helper below) could be macros just fine. Are you 100% compiler will *always* inline these helpers. The likelyhood of not inlining is minimal, sure, but what do we get for writing these as functions instead of macros ? also, lacking commit log -- balbi
signature.asc
Description: PGP signature
