Hi Paul, On Mon, Sep 28, 2015 at 9:51 PM, Paul Gortmaker <paul.gortma...@windriver.com> wrote: > In a previous merge window, we made changes to allow better > delineation between modular and non-modular code in commit > 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init > from init.h to module.h"). This allows us to now ensure module code > looks modular and non-modular code does not accidentally look modular > just to avoid suffering build breakage. > > Here we target code that is, by nature of their Makefile and/or > Kconfig settings, only available to be built-in, but implicitly > presenting itself as being possibly modular by way of using modular > headers, macros, and functions. > > The goal here is to remove that illusion of modularity from these > files, but in a way that leaves the actual runtime unchanged. > In doing so, we remove code that has never been tested and adds > no value to the tree. And we continue the process of expecting a > level of consistency between the Kconfig/Makefile of code and the > code in use itself. > > Fortuntately the net subsystem has relatively few instances, given > the overall amount of code and drivers it contains. For comparison > there are over 300 instances tree wide, resulting in a possible net > removal of on the order of 5000 lines of unused code. > > Build tested on net-next 34c2d9fb0498 on m68k, since that is the arch > where the three ethernet drivers changed here are available.
> net/ethernet: make amd/hplance.c driver explicitly non-modular > net/ethernet: make 8390/mac8390.c driver explicitly non-modular > net/ethernet: make apple/macmace.c driver explicitly non-modular Why did you choose this approach? What about changing the "bool"s to "tristate"s in Kconfig instead? I gave it a try, and with some small changes the three m68k ethernet drivers build fine as modular drivers. I can send patches if you like it. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html