From: Paolo Abeni <pab...@redhat.com> Date: Fri, 25 Sep 2015 15:16:58 +0200
> Such hosts are going to silently discard the ICMP redirect > messages generated by the VRRP router since the message's source > IP will differ from the redirected route's gateway. > > RFC1122 don't imposes the above check, so this patch makes ... I don't know if it's a question of terminology but RFC1122 does seem to ask us to make this check, from 3.2.2.2: A Redirect message SHOULD be silently discarded if ... the source of the Redirect is not the current first-hop gateway for the specified destination (see Section 3.3.1). And that seems to be exactly what this "rt->rt_gateway != old_gw" test is implementing. Furthermore, from a completely pragmatic perspective, pushing this looser requirement down into the hosts is going to be a deployment nightmare. Whereas if we changed the routers to send ICMP redirects that these hosts would actually accept, you'd only have to make the change on the routers. This is several orders of magnitude easier to deploy. So I'm not going to apply this, sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html