Please do not top-post on netdev and/or lkml
On Mon, 2015-10-12 at 00:14 +0100, Ben Cox wrote: > Nice! > > That works in my head at least, Sorry about not seeing that fairly > glaring memory issue there. No problem, this is why we review patches ;) > > Are you sure " skb->transport_header += iphlen; " won't have a knock > on affect when it's given to NF_HOOK ( as in, would a potential > userspace program get something it does not expect anymore ) ? netfilter does not depend on transport_header being set (otherwise as you can see RAW packets would have problems with netfilter since the very beginning. > How does submission work at this point if the above is not a issue > (apologies if this is already in a FAQ somewhere I missed)? > Just send a V2 of the patch, using following title : [PATCH v2 net] raw: increment correct SNMP counters for ICMP messages I'll add my 'Acked-by:' after your 'Signed-off-by:' Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
