Yuval Mintz <[email protected]> :
[...]
> > > +struct qed_simd_fp_handler {
> > > + void *token;
> > > + void (*func)(void *);
> > > +};
> > Use union * ?
> The token is a cookie to be used by a func, so union isn't appropriate.
Lets' reformulate: replace 'void * token' by 'union foobar *token'.
void * silents compiler. union * doesn't.
[...]
> > > + rc = -ENOMEM;
> > > + goto ilt_shadow_fail;
> > > + } else {
> > > + DP_VERBOSE(p_hwfn, QED_MSG_ILT,
> > > + "Allocated 0x%x bytes for ilt shadow\n",
> > > + (u32)(size * sizeof(struct qed_dma_mem)));
> > > + }
> > The "else" branch after the "goto" isn't idiomatic.
> Not that I mind, but is such a prefernce described in any style-guide?
Documentation/CodingStyle gives some hints in its "goto" section but it
doesn't specifically go that far. Is there a reward if I can exhumate
some message on netdev where it would had already been outlined ?
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
